Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic #155

Closed
tomara-x opened this issue May 1, 2024 · 5 comments
Closed

panic #155

tomara-x opened this issue May 1, 2024 · 5 comments

Comments

@tomara-x
Copy link
Owner

tomara-x commented May 1, 2024

Screenshot_2024-05-01_16-15-43

this panics when duplicating the top right empty at order 2 (doesn't matter it can be at order 1)

scene file: process.txt

@tomara-x
Copy link
Owner Author

tomara-x commented May 1, 2024

actually, duplicating any circle at an order > 0 in this scene will panic

@tomara-x
Copy link
Owner Author

tomara-x commented May 1, 2024

smaller reproduction s0.txt

tomara-x added a commit that referenced this issue May 1, 2024
some components are added in post_load, so if a circle doesn't yet have
them we don't want it in the process queue...

this avoids the panic in #155
@tomara-x
Copy link
Owner Author

tomara-x commented May 1, 2024

why does a loaded (unready) circle end up in the queue only with this setup?
how come you need a butt -> rise -> reorder and the reorder targeting a process, and if any of those conditions isn't met, things work normally?

edit: process has nothing to do with it. reorder has to target something, doesn't matter what..

@tomara-x
Copy link
Owner Author

tomara-x commented May 2, 2024

ah, it's cause rise is constantly opening the wh, so connected to a reorder meant that the reorder is always sending an OrderChange event

yup, this also does it

Screenshot_2024-05-02_09-21-27

so, b51ed80 is the best protection, but i wanna try figuring out a better way to handle rise/fall wh opening as well

@tomara-x
Copy link
Owner Author

tomara-x commented May 2, 2024

done 576cfba

@tomara-x tomara-x closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant