Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SplitPane - Resize logic updated #406

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Conversation

arpitgarg101
Copy link

@arpitgarg101 arpitgarg101 commented Dec 11, 2019

Thanks for contributing to react-split-pane!

Before submitting a pull request, please complete the following checklist:

  • The existing test suites (yarn run test) all pass
  • For any new features or bug fixes, both positive and negative test cases have been added
  • For any new features, documentation has been added
  • For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
  • Format your code with prettier (yarn run prettier).

Here is a short checklist of additional things to keep in mind before submitting:

  • Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
  • Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.548% when pulling f9f86c6 on arpitgarg101:patch-1 into 9c49aad on tomkp:v2.

@arpitgarg101
Copy link
Author

@tomkp @wuweiweiwu @davvidbaker Can you please review my PR, I am using your react-split-pane v2.0.2 npm package in one of my projects and recently I saw there is some problem with the resizing of panes. I have raised the PR #406 as a fix for that, please can you review it and merge it to v2 branch so that I can import the package in my project. It would be of great help.

Copy link
Collaborator

@wuweiweiwu wuweiweiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@wuweiweiwu wuweiweiwu merged commit 0ea05a6 into tomkp:v2 Dec 13, 2019
@arpitgarg101
Copy link
Author

arpitgarg101 commented Dec 13, 2019

@tomkp @wuweiweiwu can you publish the branch change as the npm package? So, I can import that package as in the npm package v2.0.2 I still see the old change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants