#9 Fix missing magic number in assign statement

checks/assign.go

@@ -26,22 +26,33 @@ func NewAssignAnalyzer(pass *analysis.Pass, config *config.Config) *AssignAnalyz
 func (a *AssignAnalyzer) NodeFilter() []ast.Node {
 	return []ast.Node{
 		(*ast.KeyValueExpr)(nil),
+		(*ast.AssignStmt)(nil),
 	}
 }
 
 func (a *AssignAnalyzer) Check(n ast.Node) {
-	expr, ok := n.(*ast.KeyValueExpr)
-	if !ok {
-		return
-	}
-
-	switch x := expr.Value.(type) {
-	case *ast.BasicLit:
-		if a.isMagicNumber(x) {
-			a.pass.Reportf(x.Pos(), reportMsg, x.Value, AssignCheck)
+	switch expr := n.(type) {
+	case *ast.KeyValueExpr:
+		switch x := expr.Value.(type) {
+		case *ast.BasicLit:
+			if a.isMagicNumber(x) {
+				a.pass.Reportf(x.Pos(), reportMsg, x.Value, AssignCheck)
+			}
+		case *ast.BinaryExpr:
+			a.checkBinaryExpr(x)
+		}
+	case *ast.AssignStmt:
+		for _, e := range expr.Rhs {
+			switch y := e.(type) {
+			case *ast.UnaryExpr:
+				switch x := y.X.(type) {
+				case *ast.BasicLit:
+					if a.isMagicNumber(x) {
+						a.pass.Reportf(x.Pos(), reportMsg, x.Value, AssignCheck)
+					}
+				}
+			}
 		}
-	case *ast.BinaryExpr:
-		a.checkBinaryExpr(x)
 	}
 }
 

testdata/src/assign/assign.go

@@ -1,6 +1,7 @@
 package assign
 
 import (
+	"fmt"
 	"net/http"
 	"time"
 )
@@ -28,3 +29,8 @@ func example3() *http.Client {
 
 	return c
 }
+
+func example4() {
+	res := -12 // want "Magic number: 12"
+	fmt.Println(res)
+}