Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add shape divider position options #1545

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Feature: Add shape divider position options #1545

merged 1 commit into from
Dec 2, 2024

Conversation

tomusborne
Copy link
Owner

closes #1542

shape-position.mp4

@tomusborne tomusborne added the feature Features, refactoring, enhancements, improvements label Nov 29, 2024
@tomusborne tomusborne added this to the 2.0.0 milestone Nov 29, 2024
iansvo
iansvo approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@iansvo iansvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected locally. I tested using CSS variables and regular color values too.

@tomusborne tomusborne merged commit 848982c into release/2.0.0 Dec 2, 2024
9 checks passed
@tomusborne tomusborne deleted the feature/add-shape-position-options branch December 2, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iansvo iansvo iansvo approved these changes

Assignees
No one assigned
Labels
feature Features, refactoring, enhancements, improvements
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tomusborne @iansvo