Fix async code issue. #664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnyGCn, thank you for this fix! Could you, please, revert ZH updates, as I can't solve this conflict? The localization team will update this in ZH version by themself. |
|
@AnyGCn, thank you for the fixes, I transferred them directly because this PR got stuck with conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the execution will go on immediately after invoking updateMetadataFiles(), without waiting for all the write operations to complete, You are expecting that after forEach is completed, all the async code is already executed but that is not the case. You may upload the metadata files that are not written in yet.