From d841199ac5ee064bae03e36c6d735e084d79704b Mon Sep 17 00:00:00 2001 From: David Fridrich <49119790+gauron99@users.noreply.github.com> Date: Mon, 18 Sep 2023 10:31:08 +0200 Subject: [PATCH] disable depguard temporarily & update golangci-lint (#4981) * disable depguard Signed-off-by: gauron99 * update golangci-lint version to 1.54.2 Signed-off-by: gauron99 --------- Signed-off-by: gauron99 Signed-off-by: anton.lysina --- .devcontainer/Dockerfile | 2 +- .github/workflows/pr-validation.yml | 2 +- .golangci.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile index 53b41c65d8b..fa1f5f65ac3 100644 --- a/.devcontainer/Dockerfile +++ b/.devcontainer/Dockerfile @@ -63,7 +63,7 @@ RUN apt-get update \ && mv $HOME/.local/include/ /usr/local/bin/include/ \ && protoc --version \ # Install golangci-lint - && curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.52.2 \ + && curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.54.2 \ # # Create a non-root user to use if preferred - see https://aka.ms/vscode-remote/containers/non-root-user. && groupadd --gid $USER_GID $USERNAME \ diff --git a/.github/workflows/pr-validation.yml b/.github/workflows/pr-validation.yml index a90e36e7089..e93023f2f18 100644 --- a/.github/workflows/pr-validation.yml +++ b/.github/workflows/pr-validation.yml @@ -136,7 +136,7 @@ jobs: with: go-version: "1.20" - name: Get golangci - run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.52.2 + run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.54.2 - uses: pre-commit/action@v3.0.0 trivy-scan: diff --git a/.golangci.yml b/.golangci.yml index 7d87bbc228d..f14a447b4dc 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -31,7 +31,7 @@ linters: - ineffassign - staticcheck - exportloopref - - depguard + #- depguard #https://github.com/kedacore/keda/issues/4980 - dogsled - errcheck #- funlen