Add scorecard and phase ID checks to the reviewer checks

Author: jmgasper

src/services/ChallengeService.js

@@ -2816,6 +2816,30 @@ async function updateChallenge(currentUser, challengeId, data, options = {}) {
       : Array.isArray(challenge.reviewers)
       ? challenge.reviewers
       : [];
+
+    const reviewersMissingFields = [];
+    effectiveReviewers.forEach((reviewer, index) => {
+      const hasScorecardId =
+        reviewer && !_.isNil(reviewer.scorecardId) && String(reviewer.scorecardId).trim() !== "";
+      const hasPhaseId =
+        reviewer && !_.isNil(reviewer.phaseId) && String(reviewer.phaseId).trim() !== "";
+
+      if (!hasScorecardId || !hasPhaseId) {
+        const missing = [];
+        if (!hasScorecardId) missing.push("scorecardId");
+        if (!hasPhaseId) missing.push("phaseId");
+        reviewersMissingFields.push(`reviewer[${index}] missing ${missing.join(" and ")}`);
+      }
+    });
+
+    if (reviewersMissingFields.length > 0) {
+      throw new errors.BadRequestError(
+        `Cannot activate challenge; reviewers are missing required fields: ${reviewersMissingFields.join(
+          "; "
+        )}`
+      );
+    }
+
     const reviewerPhaseIds = new Set(
       effectiveReviewers
         .filter((reviewer) => reviewer && reviewer.phaseId)

test/unit/ChallengeService.test.js

@@ -1316,6 +1316,38 @@ describe('challenge service unit tests', () => {
       }
     })
 
+    it('update challenge - prevent activating when reviewer is missing required fields', async () => {
+      const activationChallenge = await createActivationChallenge()
+      await prisma.challengeReviewer.create({
+        data: {
+          id: uuid(),
+          challengeId: activationChallenge.id,
+          scorecardId: '',
+          isMemberReview: false,
+          phaseId: data.phase.id,
+          aiWorkflowId: 'wf-missing',
+          createdBy: 'activation-test',
+          updatedBy: 'activation-test'
+        }
+      })
+
+      try {
+        await service.updateChallenge(
+          { isMachine: true, sub: 'sub-activate', userId: 22838965 },
+          activationChallenge.id,
+          {
+            status: ChallengeStatusEnum.ACTIVE
+          }
+        )
+      } catch (e) {
+        should.equal(e.message.indexOf('reviewers are missing required fields') >= 0, true)
+        return
+      } finally {
+        await prisma.challenge.delete({ where: { id: activationChallenge.id } })
+      }
+      throw new Error('should not reach here')
+    })
+
     it('update challenge - enforce reviewers for required phases', async () => {
       const setup = await createChallengeWithRequiredReviewPhases()
       try {