diff --git a/.circleci/config.yml b/.circleci/config.yml index 817d1d9..fbc92f8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -8,15 +8,13 @@ parameters: type: boolean defaults: &defaults docker: - - image: cimg/python:3.11.0-browsers + - image: circleci/python:2.7-stretch-browsers install_dependency: &install_dependency name: Installation of build and deployment dependencies. command: | - sudo apt update sudo apt install jq python3-pip - # sudo pip install docker-compose sudo pip3 install awscli --upgrade - sudo pip3 install docker-compose + # sudo pip install docker-compose install_deploysuite: &install_deploysuite name: Installation of install_deploysuite. command: | @@ -25,10 +23,10 @@ install_deploysuite: &install_deploysuite cp ./../buildscript/buildenv.sh . cp ./../buildscript/awsconfiguration.sh . restore_cache_settings_for_build: &restore_cache_settings_for_build - key: docker-node-modules-{{ checksum "yarn.lock" }} + key: docker-node-modules-{{ checksum "package-lock.json" }} save_cache_settings: &save_cache_settings - key: docker-node-modules-{{ checksum "yarn.lock" }} + key: docker-node-modules-{{ checksum "package-lock.json" }} paths: - node_modules @@ -97,13 +95,12 @@ jobs: - run: *install_deploysuite - run: name: 'newman test' - no_output_timeout: 30m command: | ./awsconfiguration.sh $DEPLOY_ENV source awsenvconf ./buildenv.sh -e $DEPLOY_ENV -b ${LOGICAL_ENV}-global-appvar,${LOGICAL_ENV}-${APPNAME}-qa-appvar source buildenvvar - npm install --loglevel verbose + npm i cd mock (npm run mock-challenge-api&) (NODE_ENV=test npm start&) diff --git a/Verification.md b/Verification.md index 03ae304..cffa15d 100644 --- a/Verification.md +++ b/Verification.md @@ -94,5 +94,4 @@ Iteration 4/4 Then you can run `npm run test:newman:clear` to delete all testing data by above postman tests. If 'socket hang up' appears while running the `npm run test:newman`. You can increase the `WAIT_TIME` from the `default/test.js`. - Then run `npm run test:newman:clear` before calling `npm run test:newman` again. - \ No newline at end of file + Then run `npm run test:newman:clear` before calling `npm run test:newman` again. \ No newline at end of file diff --git a/app-constants.js b/app-constants.js index 9dc4d3b..3db24e1 100644 --- a/app-constants.js +++ b/app-constants.js @@ -10,8 +10,7 @@ const UserRoles = { } const ChallengeStatuses = { - Completed: 'Completed', - Active: 'Active' + Completed: 'Completed' } module.exports = { diff --git a/config/test.js b/config/test.js index 0d5f18d..81cb802 100644 --- a/config/test.js +++ b/config/test.js @@ -17,7 +17,5 @@ module.exports = { COPILOT_CREDENTIALS_PASSWORD: process.env.COPILOT_CREDENTIALS_PASSWORD || '', USER_CREDENTIALS_USERNAME: process.env.USER_CREDENTIALS_USERNAME || '', USER_CREDENTIALS_PASSWORD: process.env.USER_CREDENTIALS_PASSWORD || '', - MANAGER_CREDENTIALS_USERNAME: process.env.MANAGER_CREDENTIALS_USERNAME || '', - MANAGER_CREDENTIALS_PASSWORD: process.env.MANAGER_CREDENTIALS_PASSWORD || '', AUTOMATED_TESTING_REPORTERS_FORMAT: process.env.AUTOMATED_TESTING_REPORTERS_FORMAT || ['cli', 'html'] } diff --git a/src/services/ResourceService.js b/src/services/ResourceService.js index 42de677..199fde7 100644 --- a/src/services/ResourceService.js +++ b/src/services/ResourceService.js @@ -231,10 +231,6 @@ async function init (currentUser, challengeId, resource, isCreated) { throw new errors.BadRequestError('Cannot delete resources of a completed challenge!') } - if (_.get(challenge, 'status') !== constants.ChallengeStatuses.Active && isCreated && resource.roleId === config.SUBMITTER_RESOURCE_ROLE_ID) { - throw new errors.BadRequestError(`Cannot create submitter resource on challenge with status ${_.get(challenge, 'status')}`) - } - // Prevent from creating more than 1 submitter resources on tasks if (_.get(challenge, 'task.isTask', false) && isCreated && resource.roleId === config.SUBMITTER_RESOURCE_ROLE_ID) { const existing = await getResources(currentUser, challengeId, config.SUBMITTER_RESOURCE_ROLE_ID, null, null, 1, 1) diff --git a/test/postman/newman.js b/test/postman/newman.js index bd7881e..7f029d5 100644 --- a/test/postman/newman.js +++ b/test/postman/newman.js @@ -183,17 +183,15 @@ async function clearTestData () { /** * Run the postman tests. */ -clearTestData().then(() => { - apiTestLib.runTests(requests, require.resolve('./resource-api.postman_collection.json'), - require.resolve('./resource-api.postman_environment.json')).then(async () => { - logger.info('newman test completed!') - await clearTestData() - }).catch(async (err) => { - logger.logFullError(err) +apiTestLib.runTests(requests, require.resolve('./resource-api.postman_collection.json'), + require.resolve('./resource-api.postman_environment.json')).then(async () => { + logger.info('newman test completed!') + await clearTestData() +}).catch(async (err) => { + logger.logFullError(err) - // Only calling the clean up function when it is not validation error. - if (err.name !== 'ValidationError') { - await clearTestData() - } - }) + // Only calling the clean up function when it is not validation error. + if (err.name !== 'ValidationError') { + await clearTestData() + } })