Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: when the email on signup is optional the email should not be validated #585

Closed
josecelano opened this issue Jul 9, 2024 · 0 comments · Fixed by #586
Closed

Bug: when the email on signup is optional the email should not be validated #585

josecelano opened this issue Jul 9, 2024 · 0 comments · Fixed by #586
Assignees
@josecelano
Labels
Bug Incorrect Behavior
Milestone
v3.0.0

Comments

@josecelano
Copy link
Member

You cannot leave the email field empty in the signup form even in email is optional in the configuration.

image
@josecelano josecelano added the Bug Incorrect Behavior label Jul 9, 2024
@josecelano josecelano added this to the v3.0.0 milestone Jul 9, 2024
@josecelano josecelano self-assigned this Jul 9, 2024
josecelano added a commit to josecelano/torrust-index-gui that referenced this issue Jul 9, 2024
@josecelano
fix: [torrust#585] email field if regsitration form can be empty
3d065c5 
when email is optional for registration.
@josecelano josecelano linked a pull request Jul 9, 2024 that will close this issue
Allow an empty email field in the registration form when email is optional #586
Merged
josecelano added a commit to josecelano/torrust-index-gui that referenced this issue Jul 10, 2024
@josecelano
fix: [torrust#585] email field if regsitration form can be empty
96ef18e 
when email is optional for registration.
josecelano added a commit that referenced this issue Jul 10, 2024
@josecelano
Merge #586: Allow an empty email field in the registration form when …
88a7777 
…email is optional

96ef18e fix: [#585] email field if regsitration form can be empty (Jose Celano)

Pull request description:

  Depends on: torrust/torrust-index#670

  Allow an empty email field in the registration form when email is optional in the configuration.

  To be fully fixed this [PR](torrust/torrust-index#670) has to be merged.

ACKs for top commit:
  josecelano:
    ACK 96ef18e

Tree-SHA512: d9f18e7acceeac8b8016ac8cf12fae5240b78e5f610c7ad522a56f5a5046e95e5b1b50d6c682f43a94cb2c0572968da45d276ca517b1c7e63df33a6ecda7b183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josecelano josecelano

Labels
Bug Incorrect Behavior
Projects
None yet
Milestone
v3.0.0
1 participant
@josecelano