Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not remove torrents when their categories are removed and allow torrents without categories #96

Closed
mickvandijke opened this issue Mar 16, 2023 · 1 comment · Fixed by #225
Closed

Do not remove torrents when their categories are removed and allow torrents without categories #96

mickvandijke opened this issue Mar 16, 2023 · 1 comment · Fixed by #225
Labels
Easy Good for Newcomers Enhancement / Feature Request Something New

Comments

@mickvandijke
Copy link
Member

In the current behaviour, when deleting existing categories, all torrents in that category will be removed. Instead we should move the torrents to a new permanent category called Uncategorized.
@josecelano
Copy link
Member

Today we agreed on removing the category from the torrents and allowing torrents without categories.

cc @WarmBeer @da2ce7

@josecelano josecelano changed the title Add a permanent Uncategorized category. Do not remove torrents when their categories are removed and allow torrents without categories Jun 9, 2023
@josecelano josecelano added the Easy Good for Newcomers label Jun 9, 2023
@josecelano josecelano mentioned this issue Jun 21, 2023
Closed
@josecelano josecelano linked a pull request Jun 27, 2023 that will close this issue
Make torrent category optional #224
Closed
@josecelano josecelano removed a link to a pull request Jun 27, 2023
Make torrent category optional #224
Closed
@josecelano josecelano linked a pull request Jun 27, 2023 that will close this issue
Make torrent category optional #225
Merged
@josecelano josecelano mentioned this issue Jun 27, 2023
Merged
josecelano added a commit to torrust/torrust-index-gui that referenced this issue Jun 27, 2023
@josecelano
Merge #133: Optional torrent category
11a8129 
65c6e01 feat: do not show tag list in torrent edition is there are no tags (Jose Celano)
525aad7 fix: [#2] categories can be optional (Jose Celano)

Pull request description:

  Torrent category is now optional, which means the response from the API can contain a `null` instead of a category o object.

  Relates to: torrust/torrust-index#96

Top commit has no ACKs.

Tree-SHA512: 196c17a0ac2244fee2f92b64941122c5b6d97fb3ec00e7f3baa7e692b15a13f21e5fac3fe04b53abdbd3450fa05119a0a21175979f7add65d58e740f8dfabe63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Good for Newcomers Enhancement / Feature Request Something New
Projects
Torrust Solution
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make torrent category optional
2 participants
@josecelano @mickvandijke