Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: missing tables in Database::delete_all_database_rows function #220

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix: missing tables in Database::delete_all_database_rows function #220

merged 2 commits into from
Jun 26, 2023

Commits on Jun 26, 2023

  1. test: [#194] remove database tests 

    Because:

- They are hard to maintain because of the table's dependencies.
- They are duplicated in E2E tests. And it's easier to set the state you want to test with E2E tests.

TODO: runt the E2E test using MySQL to ensure queries are OK. Currently, E2E tests are only executed with SQLite.
    @josecelano
    josecelano committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    7a06fe8 View commit details
    Browse the repository at this point in the history

  2. fix: [#194] add missing tables to truncate when reseting the DB 

    When you upgrade from v1.0.0 to v2.0.0 you can run an upgrader which
will truncate all the tables in the target database. There were some
missing tables in the list. Probably, there wre tables added after
creting the upgrader command.
    @josecelano
    josecelano committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    986d2f8 View commit details
    Browse the repository at this point in the history