Configuration overhaul: make mail-related configuration clearer #670
Commits on Jul 9, 2024
-
feat: [torrust#654] new registration confg section
Registration Disabled: ```toml ``` Registration without email option: ```toml [registration] ``` Registration optionally including an email address: ```toml [registration] [registration.email] ``` Registration with email: ```toml [registration] [registration.email] required = true ``` Registration with optional email, but if email is supplied it is verified: ```toml [registration] [registration.email] verified = true ``` Registration with email and email is verified: ```toml [registration] [registration.email] required = true verified = true ``` TODO: remove old settings and use the new ones.
-
-
feat: [torrust#654] remove config option email_verification_enabled
The config option: ```toml [mail] email_verification_enabled = false ``` was replaced with: ```toml [registration] [registration.email] verified = true ```
-
fix: bug, allow empty email is registration when it's optional
If the email in the registration form is optional the application should allow not validate it when it's emtpy. It should only validate the email when is not empty. We only make sure that if present is a valid email.
-
refactor: move ConfigurationPublic
ConfigurationPublic is not a configuration type. It does not belong to the configuration. We don't need to version this type when the configuration changes. It's a type containing a subset of the data contained in the configuration that we want to expose via the API. It happens that those are the fields we want to expose via the API becuase they are the fields we are using in the webapp (Index GUI) but it's not part of the configuration. It's a concrete view of the configration used for other purposes rather than initialize the Index app. In the future, it could be even moved to the API as a API resource. Changing this struct changes the API contract. The contract with the API consumers, not the contract with the Index administrators, the people responsible for setting up the Index and it's configuration. That the reason why it was moved from the config mod to the config service. It's not a problem now, but we should cerate an API resource for this type becuase it should be versioned in the API. WE are using versioning in the API but the type was excluded, meaning it cannot be versioned.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.