From 1db5fde0a17788629b6fd74344caf4fcaa183f96 Mon Sep 17 00:00:00 2001 From: Jonghyeon Ko Date: Sat, 3 Aug 2024 17:17:52 +0900 Subject: [PATCH] fix(*): remove unnecessary devDeps(react-dom, @types/react-dom) (#1180) # Overview ## PR Checklist - [x] I did below actions if need 1. I read the [Contributing Guide](https://github.com/toss/suspensive/blob/main/CONTRIBUTING.md) 2. I added documents and tests. --- .changeset/calm-walls-develop.md | 10 ++++++++ .changeset/config.json | 7 +++++- knip.json | 2 +- packages/cache/package.json | 4 +--- packages/jotai/package.json | 4 +--- packages/react-image/package.json | 4 +--- packages/react-query-4/package.json | 4 +--- packages/react-query-5/package.json | 4 +--- packages/react-query/package.json | 4 +--- pnpm-lock.yaml | 36 ----------------------------- 10 files changed, 23 insertions(+), 56 deletions(-) create mode 100644 .changeset/calm-walls-develop.md diff --git a/.changeset/calm-walls-develop.md b/.changeset/calm-walls-develop.md new file mode 100644 index 000000000..56a87e278 --- /dev/null +++ b/.changeset/calm-walls-develop.md @@ -0,0 +1,10 @@ +--- +"@suspensive/cache": patch +"@suspensive/jotai": patch +"@suspensive/react-image": patch +"@suspensive/react-query-4": patch +"@suspensive/react-query-5": patch +"@suspensive/react-query": patch +--- + +fix(*): remove unnecessary devDeps(react-dom, @types/react-dom) diff --git a/.changeset/config.json b/.changeset/config.json index 7d34ec262..6a7830145 100644 --- a/.changeset/config.json +++ b/.changeset/config.json @@ -11,7 +11,12 @@ "@suspensive/react-query-5" ] ], - "ignore": ["@suspensive/next-streaming-react-query", "@suspensive/visualization", "@suspensive/suspensive.org"], + "ignore": [ + "@suspensive/next-streaming-react-query", + "@suspensive/visualization", + "@suspensive/suspensive.org", + "@suspensive/react-native-playground" + ], "linked": [], "access": "restricted", "baseBranch": "main", diff --git a/knip.json b/knip.json index 650536f40..e789756a3 100644 --- a/knip.json +++ b/knip.json @@ -1,7 +1,7 @@ { "$schema": "https://unpkg.com/knip@5/schema.json", "ignoreWorkspaces": ["websites/**", "examples/**"], - "ignoreDependencies": ["coauthors", "react-dom", "@types/react-dom", "@suspensive/utils"], + "ignoreDependencies": ["coauthors", "@suspensive/utils"], "workspaces": { ".": { "ignore": ["packlint.config.mjs"] diff --git a/packages/cache/package.json b/packages/cache/package.json index 3e4ccfe17..cb393308b 100644 --- a/packages/cache/package.json +++ b/packages/cache/package.json @@ -58,9 +58,7 @@ "@suspensive/tsconfig": "workspace:*", "@suspensive/tsup": "workspace:*", "@types/react": "^18.3.3", - "@types/react-dom": "^18.3.0", - "react": "^18.3.1", - "react-dom": "^18.3.1" + "react": "^18.3.1" }, "peerDependencies": { "react": "^18" diff --git a/packages/jotai/package.json b/packages/jotai/package.json index f3f735a45..6b09b834b 100644 --- a/packages/jotai/package.json +++ b/packages/jotai/package.json @@ -57,10 +57,8 @@ "@suspensive/tsconfig": "workspace:*", "@suspensive/tsup": "workspace:*", "@types/react": "^18.3.3", - "@types/react-dom": "^18.3.0", "jotai": "^2.8.4", - "react": "^18.3.1", - "react-dom": "^18.3.1" + "react": "^18.3.1" }, "peerDependencies": { "jotai": "^2", diff --git a/packages/react-image/package.json b/packages/react-image/package.json index 02838c766..94d9c2f97 100644 --- a/packages/react-image/package.json +++ b/packages/react-image/package.json @@ -57,9 +57,7 @@ "@suspensive/tsconfig": "workspace:*", "@suspensive/tsup": "workspace:*", "@types/react": "^18.3.3", - "@types/react-dom": "^18.3.0", - "react": "^18.3.1", - "react-dom": "^18.3.1" + "react": "^18.3.1" }, "peerDependencies": { "react": "^18" diff --git a/packages/react-query-4/package.json b/packages/react-query-4/package.json index 7b3a7a301..7506849c2 100644 --- a/packages/react-query-4/package.json +++ b/packages/react-query-4/package.json @@ -60,9 +60,7 @@ "@suspensive/tsup": "workspace:*", "@tanstack/react-query": "^4.36.1", "@types/react": "^18.3.3", - "@types/react-dom": "^18.3.0", - "react": "^18.3.1", - "react-dom": "^18.3.1" + "react": "^18.3.1" }, "peerDependencies": { "@suspensive/react": "workspace:^2.12.0", diff --git a/packages/react-query-5/package.json b/packages/react-query-5/package.json index 949f0c8ef..8c7975cc3 100644 --- a/packages/react-query-5/package.json +++ b/packages/react-query-5/package.json @@ -60,9 +60,7 @@ "@suspensive/tsup": "workspace:*", "@tanstack/react-query": "^5.51.16", "@types/react": "^18.3.3", - "@types/react-dom": "^18.3.0", - "react": "^18.3.1", - "react-dom": "^18.3.1" + "react": "^18.3.1" }, "peerDependencies": { "@suspensive/react": "workspace:^2.12.0", diff --git a/packages/react-query/package.json b/packages/react-query/package.json index b55e70f09..7794e37f0 100644 --- a/packages/react-query/package.json +++ b/packages/react-query/package.json @@ -70,9 +70,7 @@ "@suspensive/tsup": "workspace:*", "@tanstack/react-query": "^4.36.1", "@types/react": "^18.3.3", - "@types/react-dom": "^18.3.0", - "react": "^18.3.1", - "react-dom": "^18.3.1" + "react": "^18.3.1" }, "peerDependencies": { "@suspensive/react": "workspace:^2.12.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index ee8e6fbb9..19fcfb378 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -356,15 +356,9 @@ importers: '@types/react': specifier: ^18.3.3 version: 18.3.3 - '@types/react-dom': - specifier: ^18.3.0 - version: 18.3.0 react: specifier: ^18.3.1 version: 18.3.1 - react-dom: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) packages/jotai: dependencies: @@ -384,18 +378,12 @@ importers: '@types/react': specifier: ^18.3.3 version: 18.3.3 - '@types/react-dom': - specifier: ^18.3.0 - version: 18.3.0 jotai: specifier: ^2.8.4 version: 2.9.1(@types/react@18.3.3)(react@18.3.1) react: specifier: ^18.3.1 version: 18.3.1 - react-dom: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) packages/react: dependencies: @@ -437,15 +425,9 @@ importers: '@types/react': specifier: ^18.3.3 version: 18.3.3 - '@types/react-dom': - specifier: ^18.3.0 - version: 18.3.0 react: specifier: ^18.3.1 version: 18.3.1 - react-dom: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) packages/react-native: dependencies: @@ -529,15 +511,9 @@ importers: '@types/react': specifier: ^18.3.3 version: 18.3.3 - '@types/react-dom': - specifier: ^18.3.0 - version: 18.3.0 react: specifier: ^18.3.1 version: 18.3.1 - react-dom: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) packages/react-query-4: dependencies: @@ -563,15 +539,9 @@ importers: '@types/react': specifier: ^18.3.3 version: 18.3.3 - '@types/react-dom': - specifier: ^18.3.0 - version: 18.3.0 react: specifier: ^18.3.1 version: 18.3.1 - react-dom: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) packages/react-query-5: dependencies: @@ -597,15 +567,9 @@ importers: '@types/react': specifier: ^18.3.3 version: 18.3.3 - '@types/react-dom': - specifier: ^18.3.0 - version: 18.3.0 react: specifier: ^18.3.1 version: 18.3.1 - react-dom: - specifier: ^18.3.1 - version: 18.3.1(react@18.3.1) packages/utils: devDependencies: