Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer using with as for action #822

Merged
merged 1 commit into from
May 14, 2018
Merged

prefer using with as for action #822

merged 1 commit into from
May 14, 2018

Conversation

gaborbernat
Copy link
Member

this is much more Pythonic

asottile
asottile approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@obestwalter
Copy link
Member

And pythonic we like :) - will be merged automatically, when tests are done.

@obestwalter obestwalter merged commit cb2dff1 into tox-dev:master May 14, 2018
@gaborbernat gaborbernat deleted the with_action branch May 14, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

@obestwalter obestwalter Awaiting requested review from obestwalter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaborbernat @obestwalter @asottile