Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename jar to come first alphabetically #1

Closed
makamys opened this issue Sep 1, 2022 · 3 comments
Closed

Rename jar to come first alphabetically #1

makamys opened this issue Sep 1, 2022 · 3 comments

Comments

@makamys
Copy link

makamys commented Sep 1, 2022

Currently the mod doesn't work well with mods that embed Mixin 0.7, such as Et Futurum Requiem, Satchels, Serene Seasons and ForgeEssentials. This happens for two reasons:

  1. Their mixin config plugins reference Mixin 0.7's shaded ASM package names (e.g. org.spongepowered.asm.lib.tree.ClassNode) which are no longer present in Mixin 0.8 [note from the future: Actually this seems to not be an issue as long as the mods don't actually use the class (and they don't), since Mixin 0.8 has a dummy ClassNode class.]
  2. They may get loaded before MixinBooterLegacy, causing Mixin 0.7 to be initialized instead of 0.8, breaking any mod that depends on the latter (such as Triangulator when MixinBooterLegacy is present).

FalsePatternLib fixes issue 1 by transforming the config plugins of all mods that use Mixin 0.7 to use the new package names. However, fixing issue 2 requires a change from MixinBooterLegacy's side.

Fortunately, it's a simple change. Since Forge loads jars in alphabetical order, the jar simply has to be renamed so that it comes before other mods alphabetically. Several other mixin bootstrap mods employ this trick:

Personally, I would recommend using ! for consistency with MixinBooter.

By the way, we are working on releasing versions of our mods without embedded Mixin, but we can't expect every mod to do this.

@tox1cozZ
Copy link
Owner

tox1cozZ commented Sep 1, 2022

MixinBooterLegacy using ! in jar name. That's exactly what it is at curseforge. Github releases for some reason do not allow loading jar with ! prefix.

@makamys
Copy link
Author

makamys commented Sep 1, 2022

Oh, I was not aware the mod was on CurseForge. In that case I'd suggest either adding a warning to the readme saying that using the GitHub releases can cause issues, or using an _ prefix in GitHub releases.

I was introduced to the mod via the GitHub repo, and other people in the same situation may run into similar issues.

@tox1cozZ
Copy link
Owner

tox1cozZ commented Sep 2, 2022

Well thank you.

@tox1cozZ tox1cozZ closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants