This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
Fix #65: assure incomplete input doesn't pass compilation #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
port tut plugin to sbt 1.0.x
Scala 2.13.0-M1
0.6.0 staging
Build tut-core for Scala 2.10 again
V0.6.1 staging
…code. Signed-off-by: Simeon H.K. fitch <fitch@astraea.io>
forward port tpolecat#188 to 0.6.x
V0.6.2 staging
… run) := true`.
WIP: fix the @&#%&$ build
modules, microsite
I had an issue where I had a bunch of warnings when running tut with the Tpolecat's scalaOptions! I took the options from: https://tpolecat.github.io/2017/04/25/scalac-flags.html Fortunately, in the FAQ, I could find a way to work around that. But the flag for unused import in the FAQ is different from the one I had in my options: `-Ywarn-unused-import` vs `-Ywarn-unused:imports` It took me way too long to figure that out, so here it is for others like me.
Docs: scalacOptions for unused imports
|
Realized this was against the wrong branch 🐶 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @tpolecat - I'm about to board a flight, but putting this up here for some quick discussion.
Currently I'm solving #65 by zipping the lines with the next line mapped to
true, if the next line closes the code-block. I then issue an error if the input is incomplete on the last line of the block.We could also solve this by collecting all the lines in a block and then once the close tag is encountered, perform the interpretation (would perhaps be cleaner) - but I know you're planning to work on doobie some yourself so didn't want to make too much of a rewrite in case you're planning on getting rid off parts of
Tut.scala.Also - tests not added, I'll happily add them in the weekend/Monday if we can proceed with this approach.
Cheers,
Felix
PS (I like that you named the category/syntax package
felix, how come? 😄)