Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conditional checks for PROTONVPN_TIER #74

Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix: Conditional checks for PROTONVPN_TIER #74

merged 1 commit into from
Sep 24, 2021

Conversation

tkimball83
Copy link
Contributor

@tkimball83 tkimball83 commented Sep 23, 2021

What does this do / why do we need it?

Using CFG_TIER in 'run' returns an empty value causing immediate failures. Use PROTONVPN_TIER as documented instead.

How this PR fixes the problem?

+ [[ '' -lt 1 ]]
+ log_error 'Using P2P requires basic plan or above!'
+ __logger_core_event_handler error 'Using P2P requires basic plan or above!'

2021-09-23 19:30:36+00:00 [INFO ] PROTONVPN_CHECK_INTERVAL is set to #60
2021-09-23 19:30:36+00:00 [INFO ] Reconnect threshold is #3
2021-09-23 19:30:36+00:00 [INFO ] Checking orphaned openvpn process
2021-09-23 19:30:36+00:00 [INFO ] This appears to be a fresh start!
2021-09-23 19:30:36+00:00 [ERROR ] Using P2P requires basic plan or above!
2021-09-23 19:30:37+00:00 [INFO ] PROTONVPN_CHECK_INTERVAL is set to #60
2021-09-23 19:30:37+00:00 [INFO ] Reconnect threshold is #3
2021-09-23 19:30:37+00:00 [INFO ] Checking orphaned openvpn process
2021-09-23 19:30:37+00:00 [INFO ] This appears to be a fresh start!
2021-09-23 19:30:37+00:00 [ERROR ] Using P2P requires basic plan or above!
2021-09-23 19:30:38+00:00 [INFO ] PROTONVPN_CHECK_INTERVAL is set to #60
2021-09-23 19:30:38+00:00 [INFO ] Reconnect threshold is #3
2021-09-23 19:30:38+00:00 [INFO ] Checking orphaned openvpn process
2021-09-23 19:30:38+00:00 [INFO ] This appears to be a fresh start!
2021-09-23 19:30:38+00:00 [ERROR ] Using P2P requires basic plan or above!

Additional Comments (if any)

Another workaround is to define CFG_TIER as a container environment variable.

@tprasadtp tprasadtp changed the title [Change] Change CFG_TIER to PROTONVPN_TIER to fix conditional fix: Conditional checks for PROTONVPN_TIER Sep 24, 2021
@tprasadtp tprasadtp added bug Issue is a bug p/high High importance labels Sep 24, 2021
@tprasadtp tprasadtp merged commit 244dbae into tprasadtp:master Sep 24, 2021
@tprasadtp tprasadtp added the s/done Completed and closed tasks/pr/issues label Sep 24, 2021
@tkimball83 tkimball83 deleted the env_cfg_tier_fix branch September 24, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug p/high High importance s/done Completed and closed tasks/pr/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants