Avoid requiring PHP's timezone settings to be set #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen parsing UTC dates. This is done by avoiding calls to strtotime(). Instead, a DateTimeZone object with UTC set as its timezone is created. When this object is passed to DateTime's constructor, PHP is pacified by being given the timezone context even though it isn't consulted.
|
Thanks for this. Just got back from holiday so still trying to catch up! Will examine, test and hopefully merge soon. |
|
Totally agree with that one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP makes a lot of notice noise when it hits the strtotime() function and the user hasn't set a timezone. This is because there's a chance that the string being parsed is not a UTC-formatted date. I think that since S3 only gives out dates in UTC, PHP is being silly in requiring that a timezone be set. However, there is no utcstrtotime() function provided by PHP which would be happy to parse timezone-independent (i.e., UTC) dates into unix timestamps.
These two commits avoid this issue. The first uses libcurl's own date parsing for handling an HTTP response's Last-Modified header. The second locally uses a UTC DateTimeZone object when parsing dates stored in the XML documents.