image buildのworkflowを1ファイルにまとめる #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
==========================================
- Coverage 74.51% 74.34% -0.17%
==========================================
Files 52 52
Lines 4163 4163
==========================================
- Hits 3102 3095 -7
- Misses 909 921 +12
+ Partials 152 147 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ras0q
commented
Jul 26, 2024
.github/workflows/image.yaml
Outdated
Comment on lines
26
to
30
| - name: Generate Image Tags | ||
| uses: docker/metadata-action | ||
| id: meta | ||
| with: | ||
| images: ghcr.io/traptitech/${{ env.IMAGE_NAME }} |
There was a problem hiding this comment.
CIのrefとeventからmetadataを作成してくれる
https://github.com/docker/metadata-action
| push: | ||
| branches: | ||
| - main | ||
| tags: | ||
| - v* | ||
| pull_request: |
There was a problem hiding this comment.
総実行時間は増えるかもしれないが一旦PR時もビルドしてみることにした
image pushはしない
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.