Fix invalid lat/lon usePreference #1080
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the right solution is to implement validation at the time you enter those values. |
|
It makes sense to add validations to both the endpoint for creating a user on the server-side and the user-add form in the web app. |
|
Agree. Do you want to update this PR or create a separate one? |
|
Cool. I will update the current PR. |
tananaev
reviewed
Feb 9, 2023
| @@ -261,13 +261,23 @@ const UserPage = () => { | |||
| <TextField | |||
| type="number" | |||
| value={item.latitude || 0} | |||
| onChange={(event) => setItem({ ...item, latitude: Number(event.target.value) })} | |||
| onChange={(event) => { | |||
There was a problem hiding this comment.
We need the same code on the server setting page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix out-of-range lat/lon error when user sets values outside of (-180, 180) and (-90, 90) respectively. The error is as shown:
