From ac27636c54b15adc8a37e511fe34a47fe7a1ac71 Mon Sep 17 00:00:00 2001 From: tiruka Date: Tue, 3 Dec 2024 11:39:11 +0900 Subject: [PATCH 1/3] fix typos in crates/burn-jit/src/tests/conv2d.rs --- crates/burn-jit/src/tests/conv2d.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/burn-jit/src/tests/conv2d.rs b/crates/burn-jit/src/tests/conv2d.rs index 061ab54e65..33d4dfbf08 100644 --- a/crates/burn-jit/src/tests/conv2d.rs +++ b/crates/burn-jit/src/tests/conv2d.rs @@ -127,7 +127,7 @@ mod tests { } #[test] - fn nchw_to_nhwc_should_match_into_contiguos() { + fn nchw_to_nhwc_should_match_into_contiguous() { let test_device = Default::default(); let input = Tensor::::random([4, 72, 53, 56], Distribution::Default, &test_device); From e028022ea89d860a4ee5c478857fd9ac396fddf3 Mon Sep 17 00:00:00 2001 From: tiruka Date: Tue, 3 Dec 2024 12:09:00 +0900 Subject: [PATCH 2/3] rename fn name with prefix 2 --- crates/burn-jit/src/tests/conv2d.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/burn-jit/src/tests/conv2d.rs b/crates/burn-jit/src/tests/conv2d.rs index 33d4dfbf08..b20224ccb6 100644 --- a/crates/burn-jit/src/tests/conv2d.rs +++ b/crates/burn-jit/src/tests/conv2d.rs @@ -127,7 +127,7 @@ mod tests { } #[test] - fn nchw_to_nhwc_should_match_into_contiguous() { + fn nchw_to_nhwc_should_match_into_contiguous_2() { let test_device = Default::default(); let input = Tensor::::random([4, 72, 53, 56], Distribution::Default, &test_device); From 1e7081ac323cb693ca597ed66155a8105ddd4484 Mon Sep 17 00:00:00 2001 From: tiruka Date: Wed, 4 Dec 2024 09:26:50 +0900 Subject: [PATCH 3/3] delete the duplicated latter test due to a review --- crates/burn-jit/src/tests/conv2d.rs | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/crates/burn-jit/src/tests/conv2d.rs b/crates/burn-jit/src/tests/conv2d.rs index b20224ccb6..8b3912d1d1 100644 --- a/crates/burn-jit/src/tests/conv2d.rs +++ b/crates/burn-jit/src/tests/conv2d.rs @@ -125,25 +125,4 @@ mod tests { into_data_sync::(output) .assert_approx_eq(&into_data_sync::(output_ref), 4); } - - #[test] - fn nchw_to_nhwc_should_match_into_contiguous_2() { - let test_device = Default::default(); - let input = - Tensor::::random([4, 72, 53, 56], Distribution::Default, &test_device); - - type Float = ::FloatElem; - - let output = nchw_to_nhwc::(input.clone().into_primitive().tensor()); - let output_ref = into_contiguous( - input - .clone() - .permute([0, 2, 3, 1]) - .into_primitive() - .tensor(), - ); - - into_data_sync::(output) - .assert_approx_eq(&into_data_sync::(output_ref), 1); - } }