Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Add instruments support for httpx #2283

Open
1 task done
damianoneill opened this issue Nov 8, 2024 · 5 comments
Open
1 task done

🚀 Feature: Add instruments support for httpx #2283

damianoneill opened this issue Nov 8, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@damianoneill
Copy link

Which component is this feature for?

All Packages

🔖 Feature description

Today the solution currently supports Instruments.REQUESTS and Instruments.URLLIB3. Is there any plans to extend the instruments to support HTTPX?

🎤 Why is this feature needed ?

Many libraries that require async support have migrated from requests to httpx. Providing httpx support natively would extend the use of this library to a larger user base.

✌️ How do you aim to achieve this?

Ideally, this feature would provide similar ease of configuration as is currently available for Requests.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

None

@dosubot dosubot bot added the enhancement New feature or request label Nov 8, 2024
@nirga
Copy link
Member

nirga commented Nov 9, 2024

Definitely @damianoneill! Do you think we should add it always by default?

@damianoneill
Copy link
Author

@nirga I think the best approach is to behave like REQUESTS since the userbase will likely use them similarly.

@nirga nirga added the good first issue Good for newcomers label Nov 9, 2024
@ghost
Copy link

ghost commented Nov 13, 2024

Hi @nirga,
I'm new to open-source and would love to take this up.

@nirga
Copy link
Member

nirga commented Nov 13, 2024

Sounds good @whoiskrtk2! Let me know if you have any questions. Should be fairly straightforward

@ghost
Copy link

ghost commented Nov 13, 2024

I plan to look into the instrumentation for requests and urllib and try to port that for httpx. It may need some work given that httpx supports asyncio and HTTP 2, but should be a good experience. I'll reach out if I get stuck anywhere. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants