Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openai): missing metric for v0 instrumentation #735

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix(openai): missing metric for v0 instrumentation #735

merged 1 commit into from
Apr 2, 2024

Conversation

nirga
Copy link
Member

@nirga nirga commented Apr 2, 2024 •
edited
Loading

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

galkleinman
galkleinman approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@galkleinman galkleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you copied it from v1 right?

@nirga nirga merged commit ffc4bd4 into main Apr 2, 2024
7 checks passed
@nirga nirga deleted the openai-v0 branch April 2, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galkleinman galkleinman galkleinman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nirga @galkleinman