Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Expose exceptions raised by other middlewares and app code #137

Closed
wants to merge 1 commit into from

Conversation

tiangolo
Copy link
Contributor

🐛 Expose exceptions raised by other middlewares and app code

It seems the traceback for other exceptions is currently hidden. This could fix/related to: #108

It seems it could also be related to: encode/starlette#1634

@Kludex
Copy link
Contributor

Kludex commented May 16, 2022

I'd say the problem is the fact that the implementation is a BaseHTTPMiddleware. 😞

@Kludex
Copy link
Contributor

Kludex commented May 16, 2022

I'll see if I can finish #23 ...

@tiangolo
Copy link
Contributor Author

This was covered/included/handled by #139, so this PR can be closed now. 😎 🔥

@tiangolo tiangolo closed this Jun 13, 2022
@tiangolo tiangolo deleted the expose-exception branch October 6, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants