Skip to content

Commit

Permalink
Unset GO111MODULE within Gimme itself
Browse files Browse the repository at this point in the history
Presumably when `GO111MODULE` is set in environ when calling `gimme`,
it's part of generic setup to be used by the Go toolchain when building
the code being CI tested and the intent is not to try to tell Go, when
building from source, that it should be requiring the new Go 1.11 module
semantics.

Forcibly unset `GO111MODULE` in Gimme itself, but do not do anything to
add this to the emitted environment variables.

Without this, `gimme master` currently fails; with this change, it
succeeds.
  • Loading branch information
philpennock committed Aug 14, 2018
1 parent 152e5e0 commit 8925443
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions gimme
Original file line number Diff line number Diff line change
Expand Up @@ -890,6 +890,8 @@ unset GOPATH
unset GOROOT
unset CGO_ENABLED
unset CC_FOR_TARGET
# GO111MODULE breaks build of Go itself
unset GO111MODULE

mkdir -p "${GIMME_VERSION_PREFIX}" "${GIMME_ENV_PREFIX}"
# The envs dir stays small and provides a record of what had been installed
Expand Down

0 comments on commit 8925443

Please sign in to comment.