-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If GIMME_DEBUG >= 2 then make.bash -v
#160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have logic to handle GIMME_DEBUG looking like a number and capturing more output here
Personally, I would like to see that logic simplified: if GIMME_DEBUG
is set and not zero, enable debugging output. No need for different levels – it is already debug level.
There's a difference between "debugging gimme" and "debugging everything gimme runs". Stacked debugging levels can be helpful. But really, I can't see a reason to want the output of |
We already have logic to handle `GIMME_DEBUG` looking like a number and capturing more output from `make.bash` here; adjust condition to make it clearer which value triggers is, and also tell `make.bash` to be more verbose and get more details in the captured log. Having `make.bash -v`, before the the #159 unset of `GO111MODULE`, this facility reveals all the `use of internal package` complaints which show that building Go itself is incompatible with having `GO111MODULE` set in environ.
aa74f98
to
74baf6a
Compare
make.bash -v
make.bash -v
@@ -327,8 +327,8 @@ _compile() { | |||
export CC_FOR_TARGET="${GIMME_CC_FOR_TARGET}" | |||
|
|||
local make_log="${1}/make.${GOOS}.${GOARCH}.log" | |||
if [[ "${GIMME_DEBUG}" -gt "1" ]]; then | |||
./make.bash 2>&1 | tee "${make_log}" 1>&2 || return 1 | |||
if [[ "${GIMME_DEBUG}" -ge "2" ]]; then |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We already have logic to handle
GIMME_DEBUG
looking like a number and capturing more output here; just use one number higher to askmake.bash
to be verbose.Slightly repetitive, but cleaner and easier to understand than conditional arrays or stuff which would affect shellcheck if we relied upon empty unquoted args being dropped.
With this and without the #159 unset of
GO111MODULE
, invoking asGIMME_DEBUG=3 GO111MODULE=on gimme master
reveals all theuse of internal package
complaints which show that building Go itself is incompatible with havingGO111MODULE
set in environ.