Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incomplete tree-sitter-c-sharp package #185

Closed
Benjamin-Davies opened this issue Aug 22, 2019 · 3 comments · Fixed by #276
Closed

Add incomplete tree-sitter-c-sharp package #185

Benjamin-Davies opened this issue Aug 22, 2019 · 3 comments · Fixed by #276

Comments

@Benjamin-Davies
Copy link

Add bindings for tree-sitter-c-sharp.

Even though it is incomplete, partial support is better than none (IMHO). Also, it is my understanding that it is easy to update bindings if the base package changes, because of the way that this project is structured.

C# is a very popular language, and I would love to see it supported in the tools that depend on this library. I am particularly excited for semantic, (link to C# issue on that repo) as it is likely to become the base of GitHub's Code Navigation.

@robrix
Copy link
Contributor

robrix commented Aug 29, 2019

Good call 👍

@damieng
Copy link
Contributor

damieng commented Apr 8, 2020

C# support is now quite complete, putting a PR together now.

@damieng damieng self-assigned this Apr 8, 2020
@patrickt
Copy link
Contributor

patrickt commented Apr 17, 2020

@damieng Awesome! Next step (sorry for telling you these things piecemeal; we’re currently fixing the docs!) is to add a semantic-c-sharp package in https://github.com/github/semantic, implement the required ToTags instances, integrate C# support into the CLI, and write some tests. Then the way forward for C# will be cleared technologically: our schedules and behind-the-scenes operational concerns (database capacity, traffic analysis, and the like) will determine when support will land. Thank you so much for all your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants