Add C# language support #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickt
approved these changes
Apr 17, 2020
|
Okay to merge? |
|
Fine by me |
|
Should I create a PR for a version bump and change-log ? |
|
Since this is the first version, we shouldn’t need any changeling updates: we should just do the rest of the steps in the release process and pop it up on Hackage. |
|
Do you need me to do those steps or is the "we" github? |
|
@damieng I think for now @tree-sitter/semantic-code should own the tree-sitter packages, though we’ll be happy to add you alongside, since you did the work! For now, you can depend on the new package directly as a pinned git version in the |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add's C# support here in order to get closer to C# semantic code support on GitHub.com
Not sure how to test this locally but the CI/GH Actions are passing including running the corpus tests.
Let me know if anything else needs to happen either on this repo, tree-sitter-c-sharp or elsewhere!
Fixes #185