From 40643a71beb8b4c504b91bcf2455118463833ca4 Mon Sep 17 00:00:00 2001 From: "Ariel Shaqed (Scolnicov)" Date: Mon, 12 Oct 2020 18:25:13 +0300 Subject: [PATCH] Silence checks warning: don't try to pass difference by reference Code was correct, but efficiency might not matter here. --- export/tasks_generator.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/export/tasks_generator.go b/export/tasks_generator.go index ad120f3c887..75e1fa31b85 100644 --- a/export/tasks_generator.go +++ b/export/tasks_generator.go @@ -120,7 +120,7 @@ func GenerateTasksFromDiffs(exportID string, dstPrefix string, diffs catalog.Dif toSignal []parade.TaskID }) - makeTaskForDiff := func(diff *catalog.Difference) (parade.TaskData, error) { + makeTaskForDiff := func(diff catalog.Difference) (parade.TaskData, error) { var ( body []byte action string @@ -187,7 +187,7 @@ func GenerateTasksFromDiffs(exportID string, dstPrefix string, diffs catalog.Dif return nil, fmt.Errorf("no \"Path\" in %+v: %w", diff, ErrMissingColumns) } - task, err := makeTaskForDiff(&diff) + task, err := makeTaskForDiff(diff) if err != nil { return nil, err } @@ -233,7 +233,7 @@ func GenerateTasksFromDiffs(exportID string, dstPrefix string, diffs catalog.Dif } ret = append(ret, parade.TaskData{ - ID: parade.TaskID(makeSuccessTaskID(successDirectory)), + ID: makeSuccessTaskID(successDirectory), Action: TouchAction, Body: &bodyStr, StatusCode: parade.TaskPending,