Skip to content

Commit

Permalink
Update docs and remove code of unuseed streaming_chunk_size and strea…
Browse files Browse the repository at this point in the history
…ming_chunk_timeout
  • Loading branch information
nopcoder committed Sep 10, 2023
1 parent 12aec00 commit 62cea17
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .secretsignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ bPxRfiCYEXAMPLEKEY
wJalrXUtnFEMI/K3MDENG/bPxRfiCYEXAMPLEKEY
wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY
zuf+tfteSlswRu7BJ86wekitnifILbZam1KYY3TG

10a718b3f285d89c36e9864494cdd1507f3bc85b342df24736ea81f9a1134bcc
6 changes: 3 additions & 3 deletions docs/reference/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,15 @@ This reference uses `.` to denote the nesting of values.
* `blockstore.s3.credentials.session_token` `(string : )` - If specified, will be used as a static session token
* `blockstore.s3.endpoint` `(string : )` - If specified, custom endpoint for the AWS S3 API (https://s3_compatible_service_endpoint:port)
* `blockstore.s3.force_path_style` `(bool : false)` - When true, use path-style S3 URLs (https://<host>/<bucket> instead of https://<bucket>.<host>)
* `blockstore.s3.streaming_chunk_size` `(int : 1048576)` - Object chunk size to buffer before streaming to blockstore (use a lower value for less reliable networks). Minimum is 8192.
* `blockstore.s3.streaming_chunk_timeout` `(time duration : "60s")` - Per object chunk timeout for blockstore streaming operations (use a larger value for less reliable networks).
* `blockstore.s3.discover_bucket_region` `(bool : true)` - (Can be turned off if the underlying S3 bucket doesn't support the GetBucketRegion API).
* `blockstore.s3.skip_verify_certificate_test_only` `(boolean : false)` - Skip certificate verification while connecting to the storage endpoint. Should be used only for testing.
* `blockstore.s3.server_side_encryption` `(string : )` - Server side encryption format used (Example on AWS using SSE-KMS while passing "aws:kms")
* `blockstore.s3.server_side_encryption_kms_key_id` `(string : )` - Server side encryption KMS key ID
* `blockstore.s3.pre_signed_expiry` `(time duration : "15m")` - Expiry of pre-signed URL.
* `blockstore.s3.disable_pre_signed` `(bool : false)` - Disable use of pre-signed URL.
* `blockstore.s3.disable_pre_signed_ui` `(bool : true)` - Disable use of pre-signed URL in the UI.
* `blockstore.s3.client_log_request` `(bool : false)` - Set SDK logging bit to log requests
* `blockstore.s3.client_log_retries` `(bool : false)` - Set SDK logging bit to log retries
* `graveler.reposiory_cache.size` `(int : 1000)` - How many items to store in the repository cache.
* `graveler.reposiory_cache.ttl` `(time duration : "5s")` - How long to store an item in the repository cache.
* `graveler.reposiory_cache.jitter` `(time duration : "2s")` - A random amount of time between 0 and this value is added to each item's TTL.
Expand Down Expand Up @@ -236,7 +236,7 @@ logging:

auth:
encrypt:
secret_key: "10a718b3f285d89c36e9864494cdd1507f3bc85b342df24736ea81f9a1134bcc09e90b6641"
secret_key: "10a718b3f285d89c36e9864494cdd1507f3bc85b342df24736ea81f9a1134bcc"

blockstore:
type: local
Expand Down
2 changes: 0 additions & 2 deletions pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,6 @@ type Config struct {
S3AuthInfo `mapstructure:",squash"`
Region string `mapstructure:"region"`
Endpoint string `mapstructure:"endpoint"`
StreamingChunkSize int `mapstructure:"streaming_chunk_size"` // deprecated
StreamingChunkTimeout time.Duration `mapstructure:"streaming_chunk_timeout"` // deprecated
MaxRetries int `mapstructure:"max_retries"`
ForcePathStyle bool `mapstructure:"force_path_style"`
DiscoverBucketRegion bool `mapstructure:"discover_bucket_region"`
Expand Down

0 comments on commit 62cea17

Please sign in to comment.