Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pebble version to support nil or 0 length keys #2419

Closed
talSofer opened this issue Aug 29, 2021 · 1 comment
Closed

Update pebble version to support nil or 0 length keys #2419

talSofer opened this issue Aug 29, 2021 · 1 comment
Labels
bug Something isn't working team/versioning-engine Team versioning engine

Comments

@talSofer
Copy link
Contributor

talSofer commented Aug 29, 2021 •
edited
Loading

Currently, lakeFS uses v0.0.0-20210308135031-3c37882d2ac8 as its pebble version. which does not support nil or 0 length keys. The support was added on cockroachdb/pebble#1135 and is available with the latest Pebble version.

Testing with the latest Pebble version (v0.0.0-20210827150156-ff43a5880feb) proved that this bugfix solves the issue. Testing included writing a ket of an empty string.
@talSofer talSofer added the bug Something isn't working label Aug 29, 2021
@arielshaqed arielshaqed added the team/versioning-engine Team versioning engine label Mar 16, 2022
@nopcoder
Copy link
Contributor

nopcoder commented May 3, 2023

Upgraded to pebble v0.0.0-20230106151110-65ff304d3d7a

@nopcoder nopcoder closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working team/versioning-engine Team versioning engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nopcoder @arielshaqed @talSofer