Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export using spark-submit #2036

Merged
merged 5 commits into from
Jun 2, 2021
Merged

Export using spark-submit #2036

merged 5 commits into from
Jun 2, 2021

Conversation

itaiad200
Copy link
Contributor

closes #2035

Still needs manual testing

@itaiad200 itaiad200 marked this pull request as draft May 31, 2021 16:16
@itaiad200 itaiad200 force-pushed the 2035-exporter-main branch from 38d44f6 to c805e49 Compare June 1, 2021 12:13
@itaiad200 itaiad200 marked this pull request as ready for review June 1, 2021 12:13
arielshaqed
arielshaqed requested changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Only required change is to make it possible for a user to understand how to run this program. Right now that's really hard.

clients/spark/core/src/main/scala/io/treeverse/clients/ExporterExec.scala Outdated Show resolved Hide resolved
clients/spark/core/src/main/scala/io/treeverse/clients/Exporter.scala Outdated Show resolved Hide resolved
clients/spark/core/src/main/scala/io/treeverse/clients/Exporter.scala Show resolved Hide resolved
@itaiad200 itaiad200 requested a review from arielshaqed June 1, 2021 14:56
arielshaqed
arielshaqed approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Approving because it's better than we had before, but please find some way of documenting usage for a user who might not be aware of Scallop.

clients/spark/core/src/main/scala/io/treeverse/clients/Exporter.scala Show resolved Hide resolved
johnnyaug
johnnyaug approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@johnnyaug johnnyaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Missing a detailed help text

clients/spark/core/src/main/scala/io/treeverse/clients/Exporter.scala Show resolved Hide resolved
@itaiad200 itaiad200 force-pushed the 2035-exporter-main branch from baf6a69 to 7159963 Compare June 2, 2021 11:45
@itaiad200 itaiad200 changed the title Export from branch main Export using spark-submit Jun 2, 2021
@itaiad200 itaiad200 merged commit 72a6d12 into master Jun 2, 2021
@itaiad200 itaiad200 deleted the 2035-exporter-main branch June 2, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@johnnyaug johnnyaug johnnyaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export should be available to use with spark-submit
3 participants
@itaiad200 @johnnyaug @arielshaqed