Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff between two references on the same branch #842

Merged
merged 5 commits into from
Oct 20, 2020
Merged

diff between two references on the same branch #842

merged 5 commits into from
Oct 20, 2020

Conversation

nopcoder
Copy link
Contributor

Closes #603

@nopcoder nopcoder self-assigned this Oct 19, 2020
arielshaqed
arielshaqed approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Discussed f2f with @nopcoder and decided to push an unrelated change (which I don't understand so cannot approve) in a separate PR.

catalog/cataloger_diff.go Outdated Show resolved Hide resolved
@nopcoder nopcoder requested a review from arielshaqed October 20, 2020 09:26
@codecov-io
Copy link

codecov-io commented Oct 20, 2020 •
edited
Loading

Codecov Report

Merging #842 into master will increase coverage by 1.29%.
The diff coverage is 72.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   43.09%   44.39%   +1.29%     
==========================================
  Files         136      137       +1     
  Lines       10648    10587      -61     
==========================================
+ Hits         4589     4700     +111     
+ Misses       5461     5277     -184     
- Partials      598      610      +12
Impacted Files Coverage Δ
catalog/db.go 81.81% <ø> (+1.58%) ⬆️
catalog/cataloger_diff.go 67.56% <72.13%> (+0.90%) ⬆️
catalog/cataloger_merge.go 61.78% <75.00%> (+0.97%) ⬆️
api/handler.go 70.52% <0.00%> (ø)
api/client.go 4.65% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6b1249...56378a1. Read the comment docs.

@nopcoder nopcoder force-pushed the feature/diff-references branch from 56378a1 to 040cc0f Compare October 20, 2020 11:32
arielshaqed
arielshaqed approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
StilLGTM.

@nopcoder nopcoder merged commit 99e1bd1 into master Oct 20, 2020
@nopcoder nopcoder deleted the feature/diff-references branch October 20, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielshaqed arielshaqed arielshaqed approved these changes

@tzahij tzahij Awaiting requested review from tzahij

Assignees

@nopcoder nopcoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diff between two references on the same branch
3 participants
@nopcoder @codecov-io @arielshaqed