self review

Author: mattseddon

extension/src/experiments/checkpoints/collect.test.ts

@@ -28,7 +28,7 @@ describe('collectHasCheckpoints', () => {
     expect(hasCheckpoints).toBe(true)
   })
 
-  it('should correctly identify a dvc.yaml without checkpoint', () => {
+  it('should correctly classify a dvc.yaml without checkpoint', () => {
     const hasCheckpoints = collectHasCheckpoints({
       stages: {
         extract: {
@@ -51,7 +51,7 @@ describe('collectHasCheckpoints', () => {
     expect(hasCheckpoints).toBe(false)
   })
 
-  it('should correctly identify a more complex dvc.yaml without checkpoint', () => {
+  it('should correctly classify a more complex dvc.yaml without checkpoint', () => {
     const hasCheckpoints = collectHasCheckpoints({
       stages: {
         evaluate: {

extension/src/experiments/checkpoints/model.ts

@@ -4,7 +4,7 @@ import { Deferred } from '@hediet/std/synchronization'
 import { collectHasCheckpoints } from './collect'
 import { findFiles } from '../../fileSystem/workspace'
 import { isSameOrChild, loadYaml, PartialDvcYaml } from '../../fileSystem'
-import { definedAndNonEmpty } from '../../util/array'
+import { definedAndNonEmpty, uniqueValues } from '../../util/array'
 
 export class ExperimentCheckpointsModel {
   public dispose = Disposable.fn()
@@ -35,8 +35,11 @@ export class ExperimentCheckpointsModel {
     if (yaml) {
       const hasCheckpoints = collectHasCheckpoints(yaml)
 
-      if (hasCheckpoints && !this.yamlWithCheckpoints.includes(path)) {
-        this.yamlWithCheckpoints.push(path)
+      if (hasCheckpoints) {
+        this.yamlWithCheckpoints = uniqueValues([
+          ...this.yamlWithCheckpoints,
+          path
+        ])
       } else {
         this.yamlWithCheckpoints = this.yamlWithCheckpoints.filter(
           file => file !== path