Ensure stub returns mock #1283
Merged
Ensure stub returns mock #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
commented
Feb 3, 2022
| describe('ExperimentsData', () => { | ||
| it('should debounce all calls to update that are made within 200ms', async () => { | ||
| stub(Watcher, 'createFileSystemWatcher').resolves(mockWatcher) | ||
| stub(Watcher, 'createFileSystemWatcher').returns(mockWatcher) |
Contributor
Author
There was a problem hiding this comment.
[F] createFileSystemWatcher is sync. This was a rake in the grass.
sroy3
approved these changes
Feb 3, 2022
rogermparent
approved these changes
Feb 3, 2022
|
Code Climate has analyzed commit d600a23 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.2%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered this whilst updating the test in prework for #1282. Didn't really fit with any of the other PRs so pulled it out.