Eliminate checkpoint race condition when updating live plots #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2022
sroy3
approved these changes
Feb 3, 2022
rogermparent
approved these changes
Feb 3, 2022
mattseddon
force-pushed
the
add-file-system-data
branch
from
e8af2a2 to
50fd368
Compare
mattseddon
force-pushed
the
wire-up-model-data
branch
from
14df444 to
41bcd5c
Compare
|
Code Climate has analyzed commit 41bcd5c and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 85.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.3%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/3
master<- #1281 <- #1282 <- thisThis PR wires together the two classes created in the previous PRs with everything else in the extension. This change means that we no longer have a race condition when checkpoint experiments start as we block the plots file watcher from firing when checkpoints experiments are running.
We do this by adding logic to
collectMutableRevisionsto return an empty array when the experiments are checkpoint based. This makes sense because all revisions are immutable when we are dealing with checkpoints.Demo
Screen.Recording.2022-02-03.at.7.44.48.pm.mov