-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RxPreferenceFragmentCompat component #239
Add RxPreferenceFragmentCompat component #239
Conversation
On the one hand: yes, this makes a lot of sense. On the other hand, I don't want to add another transitive dependency for people who don't need it. Thoughts? |
The extra dependency is really unfortunate. |
Ok, I agree with both of you. What do you think about extracting it to another module, e.g.
Since I am currently experimenting with preference data stores I can handle it. |
Yeah. I think if we want to add this, it should be in its own dependency. It's more of a pain to setup initially but it saves a lot of headache for consumers. It's how we should've done the original split between OS and support components, too. We could still go back and do it that way, in fact... |
Now it is extracted to its own dependency. |
This is great, thanks! |
I've pushed out v2.2.0 which includes this new artifact. |
PreferenceFragmentCompat
returns to grace with new android support library, since it's necessary if we want to usePreferenceDataStore
below API level 26.