Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RxPreferenceFragmentCompat component #239

Merged
merged 3 commits into from
Sep 5, 2017

Conversation

pawegio
Copy link
Contributor

@pawegio pawegio commented Aug 30, 2017

PreferenceFragmentCompat returns to grace with new android support library, since it's necessary if we want to use PreferenceDataStore below API level 26.

@dlew
Copy link
Contributor

dlew commented Aug 30, 2017

On the one hand: yes, this makes a lot of sense.

On the other hand, I don't want to add another transitive dependency for people who don't need it.

Thoughts?

@vanniktech
Copy link
Contributor

The extra dependency is really unfortunate.

@pawegio
Copy link
Contributor Author

pawegio commented Aug 30, 2017

Ok, I agree with both of you. What do you think about extracting it to another module, e.g. rxlifecycle-components-preference? I believe that it is reasonable since preference-v7 package comes with multiple fragments targeting different use cases such as:

  • PreferenceFragmentCompat (already added in this PR)
  • EditTextPreferenceDialogFragmentCompat
  • PreferenceDialogFragmentCompat
  • ListPreferenceDialogFragmentCompat

Since I am currently experimenting with preference data stores I can handle it.

@dlew
Copy link
Contributor

dlew commented Aug 30, 2017

Yeah. I think if we want to add this, it should be in its own dependency. It's more of a pain to setup initially but it saves a lot of headache for consumers.

It's how we should've done the original split between OS and support components, too. We could still go back and do it that way, in fact...

@pawegio
Copy link
Contributor Author

pawegio commented Sep 1, 2017

Now it is extracted to its own dependency.

@dlew
Copy link
Contributor

dlew commented Sep 5, 2017

This is great, thanks!

@dlew dlew merged commit bccfe16 into trello-archive:2.x Sep 5, 2017
@pawegio pawegio deleted the rx-preference-fragment-compat branch September 5, 2017 14:42
@dlew
Copy link
Contributor

dlew commented Sep 7, 2017

I've pushed out v2.2.0 which includes this new artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants