-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the "Hide balances" feature #10567
Comments
Just notes from my playing with it for a while:
I have been also experimenting with replacing blur with just a "blackening" of the data: This worked better but still the max-size of such element needs to be addressed.
|
Currently only the graph is being blurred, which can either be left as is, since it does now show any obvious scale or passed some placeholder data as well, not via the
And colored bars are definitely a no-go solution, since they are extremely obtrusive 🙏 |
Could we use some static number like 0,123456 instead of some random one every time? It would have fixed length so we would know it does not break or overflow some fields. Your opinion @Hermez-cz ? |
We've discussed blurring some time ago. I'll try to find that. But generally the way is to either blur random strings so you cannot read it through the blur or use asterisks or improved blurring. |
@MiroslavProchazka as I wrote in the issue, if only 3-5 digits are rendered, nothing will overflow for sure :D Looks much better than using the same value. Revolut does this, for example. |
Unless anyone has a better idea, let's replace the whole value with |
Let's see how it looks. Maybe we would need to use a different character (# or 8) which has the same height as numbers. Asterisk character has much smaller height. That said, it might still work, so let's see :) |
QA OK Info:
|
Currently the balances are just getting blurred but the length of the number stays the same.
Therefore, I would render a 3-5 random digit string replacing the original value contained in the
HiddenPlaceholder
.The text was updated successfully, but these errors were encountered: