Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS resolver in Trezor Suite #8618

Open
Hannsek opened this issue Jun 1, 2023 · 3 comments
Open

ENS resolver in Trezor Suite #8618

Hannsek opened this issue Jun 1, 2023 · 3 comments
Labels
blocked Blocked by external force. Third party inputs required. EVM Issues related to networks based on Ethereum Virtual Machine send Send page

Comments

@Hannsek
Copy link
Contributor

Hannsek commented Jun 1, 2023

When user type something.eth or .box, Suite will ask Blockbook for the address connected to the name and fill it inside the address field.

Screenshot 2024-05-02 at 15 11 06

Usage

  1. Send form
  2. Account name
  3. Transaction history
  4. Receive tab (? no confirmation with device)
@Hannsek Hannsek added send Send page EVM Issues related to networks based on Ethereum Virtual Machine labels Jun 1, 2023
@AdamSchinzel
Copy link
Contributor

Good idea. I was looking and the current API of blockbook doesn't have that.

Ethereum name service (ENS) operates as a set of smart contracts with two principal components: registry and resolvers. It could be in blockbook but there are also pretty good libraries for that such as wagmi (a collection of React Hooks) that has useEnsResolver hook that could be used for that.

Also in ENS Front-End Design Guidelines there is also another recommendation where to use ENS names besides inputs and that is when showing addresses in e. g. transaction history where we can show ENS names instead of almost full address. Yes we can keep both but ENS address can be shown as "primary" there.

Happy to be assigned on this.

@tomasklim
Copy link
Member

tomasklim commented Jul 18, 2023

We can also add it to transaction history as Blockbook returns those data.

It is in account.misc in Suite.
Screenshot 2024-05-02 at 15 13 13

It supports only ENS, not unstoppable domains, which we should also consider https://etherscan.io/name-lookup#

@tomasklim tomasklim added this to the Suite Trends milestone Jan 23, 2024
@tomasklim tomasklim mentioned this issue Jan 24, 2024
@tomasklim tomasklim changed the title Ethereum name service in Suite ENS resolver in Trezor Suite May 2, 2024
@tomasklim
Copy link
Member

tomasklim commented Jul 2, 2024

Waiting for trezor/blockbook#1108

@tomasklim tomasklim added the blocked Blocked by external force. Third party inputs required. label Jul 2, 2024
@tomasklim tomasklim removed this from the Suite Trends H1/2024 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by external force. Third party inputs required. EVM Issues related to networks based on Ethereum Virtual Machine send Send page
Projects
Status: No status
Development

No branches or pull requests

3 participants