Mobile: sending Solana #15533
Open
Mobile: sending Solana #15533
+66
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
trezor-ci
force-pushed
the
feat/native/send-solana
branch
from
1edfd80
to
13b6882
Compare
vytick
added
connect
vytick
requested review from
a team,
mroz22,
szymonlesisz,
martykan and
marekrjpolak
as code owners
mroz22
reviewed
Nov 25, 2024
| minFee: -1, // unused | ||
| maxFee: -1, // unused | ||
| minFee: 25000, | ||
| maxFee: 1000000000, |
There was a problem hiding this comment.
how come that suite didn't need this? 🤔
There was a problem hiding this comment.
There is probably no validation on this. And the fees are determined automatically by fetching the on chain data
PeKne
reviewed
Nov 25, 2024
suite-native/module-send/src/components/OutputsReviewFooter.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-send/src/components/OutputsReviewFooter.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-send/src/components/OutputsReviewFooter.tsx
Outdated
Show resolved
Hide resolved
suite-native/module-send/src/components/OutputsReviewFooter.tsx
Outdated
Show resolved
Hide resolved
PeKne
requested changes
Nov 25, 2024
There was a problem hiding this comment.
If I get to the state of timeouted transaction once, I am unable the send any other SOL transaction again. It always resolves in the timeout error. Only that helps is restart of the app. There is probably something rotting in the redux state.
Zaznam.obrazovky.2024-11-25.v.12.39.36.mov
vytick
force-pushed
the
feat/native/send-solana
branch
from
d05da19
to
e603734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables sending Solana and tokens including basic error handling for failed send. No custom fees are allowed (same as desktop).
d0c54f2 remove duplicate txn sending for solana
90458cd set minFee and maxFee for solana for working send form validation
5e5a100 make send for Solana work including base handling of failed txn
Related Issue
Resolve #15497
Screenshots:
happy path:
happy_path.mp4
unhappy path:
unhappy_path.mp4