Chore/update to jest 29 in suite #8726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trezor-ci
force-pushed
the
chore/suite-absolute-imports
branch
from
0437324
to
aafcc5a
Compare
mroz22
force-pushed
the
chore/update-jest-in-suite
branch
from
8b1a77e
to
fa0f912
Compare
mroz22
force-pushed
the
chore/update-jest-in-suite
branch
2 times, most recently
from
00fe842
to
39d22b6
Compare
dahaca
reviewed
Jun 20, 2023
| @@ -15,7 +15,7 @@ | |||
| "translations:list-duplicates": "yarn tsx ../suite-data/src/translations/list-duplicates.ts", | |||
| "translations:list-unused": "yarn tsx ../suite-data/src/translations/list-unused.ts", | |||
| "type-check": "tsc --build tsconfig.json", | |||
| "test:unit": "jest", | |||
| "test:unit": "jest --version && jest", | |||
There was a problem hiding this comment.
because I am interested in this information as long as there are multiple versions
There was a problem hiding this comment.
why not update all of them in this PR? :D
There was a problem hiding this comment.
please do it if you have time, will be appreciated
mroz22
force-pushed
the
chore/update-jest-in-suite
branch
7 times, most recently
from
6ac352e
to
a39b491
Compare
karliatto
approved these changes
Jun 22, 2023
| @@ -214,9 +214,6 @@ const actionCallback = ( | |||
| }; | |||
|
|
|||
| describe('useSendForm hook', () => { | |||
| beforeEach(() => { | |||
| jest.setTimeout(30000); // action sequences takes time | |||
There was a problem hiding this comment.
Maybe leaving this one to avoid flakiness. I had this test failing few times locally.
mroz22
force-pushed
the
chore/update-jest-in-suite
branch
from
a39b491
to
64ee0af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a39b491 - this one is funny. Looks at this run all the tests are marked "PASSED" but unit tests in suite package still exit with non-zero code. Interestingly, it never happens on my machine (seems to be linux related). On my machine, I am seeing those error logs but tests exit with 0. I thought myself it might be a good idea to fix it actually and the fix I am proposing is not allowing multiple calls to db before it is really migrated but I'll post the fix in another PR. Here, as a workaround, I only initiate db in the start of the test.
part of #6025