Fix a panic when exec fails with use_pty enabled #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would panic as the parent process expected the monitor process to have alreqady broken out of the event loop before sending back an error message. Which then resulted in an edge monitor message, which is only expected to be received outside the event loop, causing a panic. By using set_break we still cause the error to be sent to the parent process, while ensuring that we are no longer inside the event loop of the monitor when doing so.
marlonbaeten
approved these changes
Oct 10, 2025
Contributor
marlonbaeten
left a comment
marlonbaeten
left a comment
There was a problem hiding this comment.
I have verified this fixes the bug using:
docker run --rm -it ubuntu:25.10 bash -lc '
apt update
DEBIAN_FRONTEND=noninteractive TZ=Etc/UTC apt install -y git tzdata libpam0g-dev cargo sudo
git clone https://github.com/trifectatechfoundation/sudo-rs.git
cd sudo-rs
cargo build --release
chmod +xs target/release/sudo
target/release/sudo /tmp
git remote add bjorn3 https://github.com/bjorn3/sudo-rs.git
git fetch bjorn3
git checkout fix_exec_fail_panic
cargo build --release
chmod +xs target/release/sudo
target/release/sudo /tmp
'
squell
requested review from
squell
and removed request for
rnijveld and
squell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would panic as the parent process expected the monitor process to have alreqady broken out of the event loop before sending back an error message. Which then resulted in an edge monitor message, which is only expected to be received outside the event loop, causing a panic. By using set_break we still cause the error to be sent to the parent process, while ensuring that we are no longer inside the event loop of the monitor when doing so.