From 8d4d01c0efbb9da177418ce4a90cb587b71d07a4 Mon Sep 17 00:00:00 2001 From: nicktrn <55853254+nicktrn@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:31:18 +0000 Subject: [PATCH 1/3] deprecate cli logger warn and error methods --- packages/cli-v3/src/utilities/logger.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/cli-v3/src/utilities/logger.ts b/packages/cli-v3/src/utilities/logger.ts index 640ceaa486..64a4b3fc13 100644 --- a/packages/cli-v3/src/utilities/logger.ts +++ b/packages/cli-v3/src/utilities/logger.ts @@ -58,7 +58,9 @@ export class Logger { }; info = (...args: unknown[]) => this.doLog("info", args); log = (...args: unknown[]) => this.doLog("log", args); + /** @deprecated **ONLY USE THIS IN THE CLI** - It will hang the process when used in deployed code (!) */ warn = (...args: unknown[]) => this.doLog("warn", args); + /** @deprecated **ONLY USE THIS IN THE CLI** - It will hang the process when used in deployed code (!) */ error = (...args: unknown[]) => this.doLog("error", args); table(data: TableRow[], level?: Exclude) { const keys: Keys[] = data.length === 0 ? [] : (Object.keys(data[0]!) as Keys[]); From 1b513c3f16b9855bb44584989a7e6e141a43c89d Mon Sep 17 00:00:00 2001 From: nicktrn <55853254+nicktrn@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:41:00 +0000 Subject: [PATCH 2/3] replace broken error logger in deployed workers --- packages/cli-v3/src/executions/taskRunProcess.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/cli-v3/src/executions/taskRunProcess.ts b/packages/cli-v3/src/executions/taskRunProcess.ts index a3cc070983..22e3c9f6d5 100644 --- a/packages/cli-v3/src/executions/taskRunProcess.ts +++ b/packages/cli-v3/src/executions/taskRunProcess.ts @@ -84,7 +84,7 @@ export class TaskRunProcess { try { await this.#flush(); } catch (err) { - logger.error("Error flushing task run process", { err }); + console.error("Error flushing task run process", { err }); } await this.kill(); @@ -94,7 +94,7 @@ export class TaskRunProcess { try { await this.#flush(); } catch (err) { - logger.error("Error flushing task run process", { err }); + console.error("Error flushing task run process", { err }); } if (kill) { From 1e5b4009576ef1f3234f13626df5a2b1920c1a2f Mon Sep 17 00:00:00 2001 From: nicktrn <55853254+nicktrn@users.noreply.github.com> Date: Wed, 27 Nov 2024 15:45:57 +0000 Subject: [PATCH 3/3] changeset --- .changeset/ninety-teachers-fold.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/ninety-teachers-fold.md diff --git a/.changeset/ninety-teachers-fold.md b/.changeset/ninety-teachers-fold.md new file mode 100644 index 0000000000..7d40ec2579 --- /dev/null +++ b/.changeset/ninety-teachers-fold.md @@ -0,0 +1,5 @@ +--- +"trigger.dev": patch +--- + +Prevent certain log statements from hanging deployed worker processes