From d35895497b2854797cb3c772b7f6bae792af7ce7 Mon Sep 17 00:00:00 2001 From: Michiel De Smet Date: Tue, 13 Sep 2022 15:34:13 +0200 Subject: [PATCH] Fix sqlalchemy flaky tests --- tests/integration/test_sqlalchemy_integration.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/integration/test_sqlalchemy_integration.py b/tests/integration/test_sqlalchemy_integration.py index 1dc8f05a..fe9a788e 100644 --- a/tests/integration/test_sqlalchemy_integration.py +++ b/tests/integration/test_sqlalchemy_integration.py @@ -102,7 +102,9 @@ def test_insert(trino_connection): schema="test") metadata.create_all(engine) ins = users.insert() - conn.execute(ins, {"id": 2, "name": "wendy", "fullname": "Wendy Williams"}) + result = conn.execute(ins, {"id": 2, "name": "wendy", "fullname": "Wendy Williams"}) + # TODO: Can we get rid of this? + result.fetchall() query = sqla.select(users) result = conn.execute(query) rows = result.fetchall() @@ -126,11 +128,13 @@ def test_insert_multiple_statements(trino_connection): schema="test") metadata.create_all(engine) ins = users.insert() - conn.execute(ins, [ + result = conn.execute(ins, [ {"id": 2, "name": "wendy", "fullname": "Wendy Williams"}, {"id": 3, "name": "john", "fullname": "John Doe"}, {"id": 4, "name": "mary", "fullname": "Mary Hopkins"}, ]) + # TODO: Can we get rid of this? + result.fetchall() query = sqla.select(users) result = conn.execute(query) rows = result.fetchall()