Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ulimits guidance to deployment doc #5066

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Adding ulimits guidance to deployment doc #5066

merged 1 commit into from
Sep 24, 2020

Conversation

m57lyra
Copy link
Contributor

@m57lyra m57lyra commented Sep 3, 2020

  • balanced comments regarding modern linux systems and field observations
  • explicit that the ulimit is for the user that the presto process runs as

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2020
@m57lyra m57lyra added the docs label Sep 3, 2020
@m57lyra
Copy link
Contributor Author

m57lyra commented Sep 3, 2020

Changes so far...

Screen Shot 2020-09-03 at 3 03 24 PM

@m57lyra m57lyra force-pushed the open-file-descr-ulimit branch from 354488a to e3eeb86 Compare September 4, 2020 02:47
@m57lyra
Copy link
Contributor Author

m57lyra commented Sep 4, 2020

Hi folks! I went ahead and pushed the proposed changes, but did not remove the current limit checks from the code. Happy to make further changes as needed.

@m57lyra m57lyra force-pushed the open-file-descr-ulimit branch from e3eeb86 to 1966a8c Compare September 10, 2020 16:38
@m57lyra m57lyra force-pushed the open-file-descr-ulimit branch from 1966a8c to cddb5c4 Compare September 10, 2020 20:39
@mosabua
Copy link
Member

mosabua commented Sep 14, 2020

@electrum can you detail any other changes that are needed from a technical point of view. @m57lyra and myself are not sure what @kbajda and yourself agree on and what should be in the document now.

@m57lyra m57lyra force-pushed the open-file-descr-ulimit branch from cddb5c4 to c94663e Compare September 18, 2020 04:46
@electrum electrum merged commit c2217b7 into trinodb:master Sep 24, 2020
@m57lyra m57lyra deleted the open-file-descr-ulimit branch September 29, 2020 18:37
@nineinchnick nineinchnick mentioned this pull request Aug 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dain dain dain left review comments

@mosabua mosabua mosabua approved these changes

@electrum electrum electrum approved these changes

@willmostly willmostly Awaiting requested review from willmostly

Assignees
No one assigned
Labels
cla-signed docs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m57lyra @mosabua @electrum @dain @willmostly