[AMD][BACKEND] Switch to code object v5 #5005
Conversation
| @@ -311,7 +311,7 @@ jobs: | |||
| runner: ${{fromJson(needs.Runner-Preparation.outputs.matrix-HIP)}} | |||
| name: Integration-Tests (${{matrix.runner[1] == 'gfx90a' && 'mi210' || 'mi300x'}}) | |||
| container: | |||
| image: rocm/pytorch:rocm6.1_ubuntu22.04_py3.10_pytorch_2.4 | |||
| image: rocm/pytorch:rocm6.2.2_ubuntu22.04_py3.10_pytorch_release_2.3.0 | |||
There was a problem hiding this comment.
I couldn't find rocm 6.2 images with pytorch 2.4. Maybe someone could point me to them.
There was a problem hiding this comment.
Why do you need pytorch 2.4?
Previously we need pytorch 2.3 (or 2.2) for fp8 support.
There was a problem hiding this comment.
I recall some interpreter tests failed due to old pytorch version (which didn't support some types). I cannot recall the exact details though.
AlexAUT
force-pushed
the
switchToCOV5
branch
4 times, most recently
from
8cf7619
to
d5b5d81
Compare
AlexAUT
force-pushed
the
switchToCOV5
branch
from
d5b5d81
to
36fa63c
Compare
| @@ -234,5 +234,5 @@ Supported Platforms: | |||
| Supported Hardware: | |||
|
|
|||
| - NVIDIA GPUs (Compute Capability 8.0+) | |||
| - AMD GPUs (ROCm 5.2+) | |||
| - AMD GPUs (ROCm 6.2+) | |||
There was a problem hiding this comment.
So rocm 5.x is no longer supported?
There was a problem hiding this comment.
Due to the switch to cov5 test_optimize_thread_locality and some device_prints (the new test) will cause segfaults on 6.1 and 6.0, I haven't tested 5.x versions.
There was a problem hiding this comment.
I think we need to chat a bit regarding when to land this then, given it's a breaking change.
…ch 2.5.1 installation
Switches to code object v5 which requires to bump
rocmto6.2+to avoid segfaults fordevice_printsandtl.num_programs.The added unit test covers the previous
segfaultwithdevice_printsfor 2d tensors.This is a preparation to test llvm/llvm-project@c4d8920
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)