Update project to Swift 5 and Update Dependencies #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Folks, do you need any updates? Or you are no longer mantaining this library? |
|
@fbeeper Hey, thank you for tackling this and sorry that this has taken so long. The project got lost in the shuffle of things and fell off of our radar. Going to see what I can do to get this merged and see if I can resurrect the project so it stays relevant. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello trivago!
We updated the framework and test targets (iOS and macOS) to Swift 5.
We also updated all dependencies:
antitypical/Resultto4.1.0(Swift 4.2 / Compatible with Swift 5's Result)jspahrsummers/xcconfigsto1.0(for Xcode 10.2)AliSoftware/OHHTTPStubsto7.0(Swift 4.2)Quick/Quickto2.1.0(Swift 4.2)Quick/Nimbleto `8.0.1 (Swift 4.2)Updates to the project were minor. All tests are passing.
Looking forward for your feedback. We'll be happy to address any changes you think would be necessary or nice to have.
Notes:
3.7.0but, probably, this is something you'll like us to leave out of the PR, right?