Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project refactor #130

Merged
merged 22 commits into from
Jan 4, 2024
Merged

Project refactor #130

merged 22 commits into from
Jan 4, 2024

Conversation

donnywdavis
Copy link
Contributor

@donnywdavis donnywdavis commented Mar 28, 2021

The long overdue PR to update the project.

There were several places in the project that were outdated, such as using the Result dependency, outdated scripts, broken CI config, etc. Due to this it was a bit easier to just completely refactor the project setup and start from a clean slate. A big piece of this update was that I wanted to add proper SPM support, so I configured the project from the beginning as a Swift Package. Once that was setup then I added back support for Carthage and Cocoapods. I also wanted to move the CI setup from CircleCI to GitHub Actions.

To reduce dependencies, I converted all of the tests to XCTest and removed the need for Quick and Nimble. The only dependency that remains is for OHHTTPStubs, but this is only needed for the tests.

There were no changes to the actual code of the framework, this was strictly a cosmetic and structural change to the project. I hope that this helps in keeping the project up to date more often going forward.

NOTE
The Xcode project is only needed for Carthage support and does not include references for the tests. Open the root of the project in Xcode and it will open it as a Swift Package. You only need to open the Xcode project itself to verify that it builds for each scheme. You can also run carthage build --no-skip-current from the command line to verify the Carthage setup.

@donnywdavis donnywdavis self-assigned this Mar 28, 2021
@donnywdavis donnywdavis force-pushed the feature/project-refactor branch 2 times, most recently from 4b3bac2 to ba12914 Compare March 28, 2021 14:57
@donnywdavis donnywdavis force-pushed the feature/project-refactor branch from ba12914 to ec261f1 Compare March 28, 2021 14:58
@donnywdavis donnywdavis force-pushed the feature/project-refactor branch from 438a8a8 to 03a57e8 Compare April 3, 2021 07:40
@donnywdavis donnywdavis requested a review from bckr April 5, 2021 07:15
@rwgrier
Copy link

rwgrier commented Feb 18, 2022

@donnywdavis checking to see if there's been (or going to be) any progress on this. Looks like some nice improvements here. I also wouldn't mind moving to a Swift package for Heimdallr.swift. Thanks!

@donnywdavis donnywdavis marked this pull request as ready for review January 4, 2024 09:03
@donnywdavis donnywdavis merged commit 2aede71 into master Jan 4, 2024
1 check passed
@donnywdavis donnywdavis deleted the feature/project-refactor branch January 4, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants