-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project refactor #130
Merged
Merged
Project refactor #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnywdavis
force-pushed
the
feature/project-refactor
branch
2 times, most recently
from
March 28, 2021 14:57
4b3bac2
to
ba12914
Compare
donnywdavis
force-pushed
the
feature/project-refactor
branch
from
March 28, 2021 14:58
ba12914
to
ec261f1
Compare
donnywdavis
force-pushed
the
feature/project-refactor
branch
from
April 3, 2021 07:40
438a8a8
to
03a57e8
Compare
@donnywdavis checking to see if there's been (or going to be) any progress on this. Looks like some nice improvements here. I also wouldn't mind moving to a Swift package for Heimdallr.swift. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The long overdue PR to update the project.
There were several places in the project that were outdated, such as using the
Result
dependency, outdated scripts, broken CI config, etc. Due to this it was a bit easier to just completely refactor the project setup and start from a clean slate. A big piece of this update was that I wanted to add proper SPM support, so I configured the project from the beginning as a Swift Package. Once that was setup then I added back support for Carthage and Cocoapods. I also wanted to move the CI setup from CircleCI to GitHub Actions.To reduce dependencies, I converted all of the tests to
XCTest
and removed the need forQuick
andNimble
. The only dependency that remains is forOHHTTPStubs
, but this is only needed for the tests.There were no changes to the actual code of the framework, this was strictly a cosmetic and structural change to the project. I hope that this helps in keeping the project up to date more often going forward.
NOTE
The Xcode project is only needed for Carthage support and does not include references for the tests. Open the root of the project in Xcode and it will open it as a Swift Package. You only need to open the Xcode project itself to verify that it builds for each scheme. You can also run
carthage build --no-skip-current
from the command line to verify the Carthage setup.