Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for null response body with null body status #5

Closed
wants to merge 29 commits into from
Closed

Check for null response body with null body status #5

wants to merge 29 commits into from

Conversation

trivikr
Copy link
Owner

@trivikr trivikr commented May 18, 2023 •
edited
Loading

This PR attempt to add test which can reproduce null response body with null body status:

trivikr added 16 commits May 18, 2023 09:14
@trivikr
fix: use closest available commit position to v112
5c10203
@trivikr
chore: add tests for Chrome v113
736b2fe
@trivikr
chore: add comments on chromium versions used
8c64a7b
@trivikr
chore(ci): print location to Chrome Binary
86f2ab3
@trivikr
chore(ci): print Chrome Binary version
ef177b7
@trivikr
chore(ci): add step to override CHROME_BIN
692c74c
@trivikr
fix(ci): split commands into multiple lines
9585b0d
@trivikr
fix(ci): set up CHROME_BIN for v113
f1f2481
@trivikr
chore: add check only for undefined to confirm failure in Chrome v113
45e60da
@trivikr
chore(ci): print Chrome version before running test
ad4a983
@trivikr
fix(ci): setup CHROME_BIN before running test
71c2b84
@trivikr
chore(ci): set name to test
abdf642
@trivikr
fix(ci): set up CHROMIUM_BIN
48ab565
@trivikr
chore(ci): use CHROME_BIN in tests
136da63
@trivikr
chore: create reusable workflow for running tests on specific chrome-…
9992426 
…version

Docs: https://docs.github.com/en/actions/using-workflows/reusing-workflows
@trivikr
chore(ci): add test for Chrome v100
47a1e1d
@trivikr trivikr changed the title Check for undefined vs null between Chromium v112 and v113 Check for undefined vs null in Chrome <=v113 May 18, 2023
@trivikr trivikr changed the title Check for undefined vs null in Chrome <=v113 Check for null response body with null body status May 18, 2023
@trivikr trivikr mentioned this pull request May 19, 2023
Open
@trivikr trivikr closed this Nov 3, 2023
@trivikr trivikr deleted the chrome-v112-vs-v113-testing branch November 3, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trivikr