-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple self-cooked time integration faking the interface of OrdinaryDiffEq #272
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #272 +/- ##
==========================================
+ Coverage 79.74% 86.71% +6.96%
==========================================
Files 66 68 +2
Lines 11885 12108 +223
==========================================
+ Hits 9478 10499 +1021
+ Misses 2407 1609 -798
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great to have! Especially since now it will be possible to also port the 3S* scheme such that we can fix the test setups that use that scheme. I just have a few questions and some polite requests for more commentary
The self-cooked RK method doesn't supportresize!
yet, so you can't use AMR with it. However, I don't think that's necessary to demonstrate how to create our own time integrator, which is the main purpose of this PR.